Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upkeep: complete deprecation of ald #399

Closed
jdhoffa opened this issue Apr 26, 2022 · 0 comments · Fixed by #462
Closed

upkeep: complete deprecation of ald #399

jdhoffa opened this issue Apr 26, 2022 · 0 comments · Fixed by #462
Assignees
Labels
upkeep maintenance, infrastructure, and similar

Comments

@jdhoffa
Copy link
Member

jdhoffa commented Apr 26, 2022

See this brief blog post explaining the decision: https://2degreesinvesting.github.io/posts/2022-03-02-ald-becomes-abcd/

In r2dii.match, the key changes in the API will be:

  • The function argument match_name(..., ald) -> match_name(..., abcd)
  • The output of match_name contains added columns name_ald, sector_ald, these will become name_abcd, sector_abcd
  • The input of prioritize() expects a datasets with columns name_ald and sector_ald, we will need to make it flexible to take two different kinds of input (name_abcd, sector_abcd)

In documentation:

  • All references to ald_demo should now reference abcd_demo (must wait for this PR to be merged and pushed to CRAN).

AB#10183

@jdhoffa jdhoffa added priority upkeep maintenance, infrastructure, and similar labels May 19, 2023
@jdhoffa jdhoffa added ADO Add issue to ADO and removed priority labels Jan 26, 2024
@jdhoffa jdhoffa self-assigned this Feb 6, 2024
@jdhoffa jdhoffa changed the title Deprecate references to ALD in favour of ABCD upkeep: complete deprecation of ald Mar 6, 2024
@jdhoffa jdhoffa removed the ADO Add issue to ADO label Mar 6, 2024
@jdhoffa jdhoffa added ADO Add issue to ADO and removed ADO Add issue to ADO labels Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant