Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with NAs in columns on which we call min(), max(), sum(), etc. #326

Open
maurolepore opened this issue Jun 20, 2021 · 0 comments
Open

Comments

@maurolepore
Copy link
Contributor

maurolepore commented Jun 20, 2021

It's pretty common for a dataset to have missing values. AFAIK we haven't tested how the code behaves with missing values. From all columns I would first focus on those on which we call min(), max(), sum(), and any other function that we are now calling with the default na.rm = FALSE.

sum(c(1, NA))
#> [1] NA
max(c(1, NA))
#> [1] NA
min(c(1, NA))
#> [1] NA

sum(c(1, NA), na.rm = TRUE)
#> [1] 1
max(c(1, NA), na.rm = TRUE)
#> [1] 1
min(c(1, NA), na.rm = TRUE)
#> [1] 1

Created on 2021-07-01 by the reprex package (v2.0.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant