Label scenario #476
Merged
Label scenario #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdhoffa
reviewed
Apr 28, 2022
| @@ -6,5 +6,6 @@ | |||
| ## usethis namespace: start | |||
| #' @importFrom dplyr n | |||
| #' @importFrom scales percent | |||
| #' @importFrom stringr str_count | |||
There was a problem hiding this comment.
I would tend to prefer calling stringr::str_count so it's explicit where the stringr dependency is?
There was a problem hiding this comment.
Ah it looks like you do anyways. So you can probably remove this line
There was a problem hiding this comment.
I think that if I remove this line then the checks will not pass?
jdhoffa
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #230
In this PR I change the labelling functions so that the scenario name is part of
qplot_techmix()label.