Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plot dvv fails when only one pair is being used #118

Closed
Corentin3 opened this issue Aug 24, 2018 · 6 comments
Closed

plot dvv fails when only one pair is being used #118

Corentin3 opened this issue Aug 24, 2018 · 6 comments
Milestone

Comments

@Corentin3
Copy link

Corentin3 commented Aug 24, 2018

compute_dtt does not plot anything when only one pair is being used. Dirty fix is to comment lines 137-141.

tmp2 = allbut[dttname].resample('D').mean()
tmp2.plot(label='mean',)
tmp3 = allbut[dttname].resample('D').median()
tmp3.plot(label='median')

Also added an argument for the components in the .csv saved (l.131)

@ThomasLecocq
Copy link
Member

ThomasLecocq commented Aug 27, 2018

"does not plot anything"

but does it exit with an error? or ?

What do you mean by

Also added an argument for the components in the .csv saved (l.131)

where did you do that ? Did you update the msnoise/scripts/msnoise.py command line interface for this ?

Dirty fix

not acceptable :-) Clean fix please :)

@Corentin3
Copy link
Author

but does it exit with an error? or ?

See the error below:

image

where did you do that ? Did you update the msnoise/scripts/msnoise.py command line interface for this ?

I did this at line 131 and I just call the script as I used tod o:
pair1.to_csv('%s-m%i-f%i-c%s.csv'%(pair, mov_stack, filterid,comp))

not acceptable :-) Clean fix please :)

Well it works fine ;-)

@ThomasLecocq
Copy link
Member

I did this at line 131 and I just call the script as I used tod o:
pair1.to_csv('%s-m%i-f%i-c%s.csv'%(pair, mov_stack, filterid,comp))

Aaaah, ok, just a naming stuff; The export CSV shouldn't actually be done 1/there 2/automatically...

@ThomasLecocq ThomasLecocq changed the title compute_dtt does not plot anything when only one pair is being used plot dvv fails when only one pair is being used Aug 31, 2018
@ThomasLecocq ThomasLecocq added this to the 1.6 milestone Dec 26, 2018
@Corentin3
Copy link
Author

With the new version it still fails. Found a dirty hack to get the right .csv but... it's dirty

@ThomasLecocq
Copy link
Member

I was waiting for you to write the code and PR :-)

@Corentin3
Copy link
Author

With the new download of the master version, the script disappeared... Will work on a new one then and will keep you posted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants