Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hip-config.cmake always links against x86 compiler-rt lib #2215

Open
haampie opened this issue Jan 11, 2021 · 1 comment
Open

hip-config.cmake always links against x86 compiler-rt lib #2215

haampie opened this issue Jan 11, 2021 · 1 comment

Comments

@haampie
Copy link
Contributor

haampie commented Jan 11, 2021

Over here in hip-config.cmake.in

https://github.com/ROCm-Developer-Tools/HIP/blob/main/hip-config.cmake.in#L208-L214

the compiler-rt lib to link to is fixed to clang_rt.builtins-x86_64.

This does not seem to work cross-platform, since the library name is generally libclang_rt.builtins-<arch>.a.

Wouldn't it be better to add the --rtlib=compiler-rt flag when using clang? That should work cross-architecture.

Or how about dropping fp16 support altogether from hip::host? It seems a bit arbitrary to me. And since fp16 support on x86 is almost non-existent, can't you make the user themselves add --rtlib=compiler-rt? GCC only supports it on ARM anyways, so it's very unlikely people would work with fp16 on x86.

@ppanchad-amd
Copy link

@haampie Is this ticket still relevant? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants