Fixing a HIP bug that causes DEBUG symbols to be dropped. #588
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that in the generated makefiles, we'd have
However, if you take a look at lines 442 through 448, all the configuration endings are capitalized. Since CMake is case sensitive, you'll end up with empty Debug flags.
i.e. we'd end up setting HIP_HCC_FLAGS_DEBUG but looked at HIP_HCC_FLAGS_Debug (which is an empty variable).
This PR fixes this bug by correctly capitalizing the build_configuration variable.