Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding prof primitives generator #967

Merged
merged 5 commits into from Mar 20, 2019
Merged

adding prof primitives generator #967

merged 5 commits into from Mar 20, 2019

Conversation

eshcherb
Copy link
Contributor

No description provided.

mangupta
mangupta requested changes Mar 17, 2019
View reviewed changes
Copy link
Contributor

@mangupta mangupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hip_prof_gen.py is needed only while building HIP. Files in HIP_SRC/bin are binaries that need to be installed on target system. So hip_prof_gen.py should not be in HIP_SRC/bin. Instead it should be moved to HIP_SRC.

@mangupta mangupta merged commit 673cdee into ROCm:master Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mangupta mangupta mangupta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eshcherb @mangupta