Fixes related to distro's filesystems #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using: $HIP_CLANG_PATH."/../lib/clang/".$HIP_CLANG_VERSION; Isn't always correct, as the library and resource directory can be customized at build time in LLVM. E.g. Fedora, RHEL, and SLE uses "lib64/clang" instead of "lib/clang". So it's better to ask clang where its resource directory is instead. Change-Id: I026b245735af5e5310b9ee6188f3f080fac6eb51 Signed-off-by: Jeremy Newton <Jeremy.Newton@amd.com>
Instead of checking for windows, it seems better to detect the location of the clang binary. Normally distros put clang bin in the same directory as hipcc, so this will improve the experience there too. Change-Id: I506faa15c8cc69500436f2dec3cdfd3f86356fab Signed-off-by: Jeremy Newton <Jeremy.Newton@amd.com>
|
Update: I added the fix for clang detection to hipcc.bin as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When packaging hipamd with Fedora, these are some issues that came up.
They seem generic to most distros, so we should pull them in if there's no issue.
This is a resubmit of:
ROCm/HIP#3239