[HIPIFY][BLAS][fix] Fix hipBLAS and rocBLAS TRMM functions support types #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Mark rocBLAS TRMM functions rocblas_(s|d|c|z)trmm_outofplace, as supported only for TRMM v2 CUDA analogues + Mark hipBLAS TRMM functions hipblas(S|D|C|Z)trmm as HIP_UNSUPPORTED + Regenerate and update docs and hipify-perl accordingly [Reasons] + hipBLAS TRMM functions hipblas(S|D|C|Z)trmm, actually, do not match neither cublas TRMM functions, nor cublas TRMM _v2 functions: ROCm/hipBLAS#524 + There is a correspondence between cuBLAS cublas_(s|d|c|z)trmm and rocBLAS TRMM rocblas_(s|d|c|z)trmm_outofplace, not rocblas_(s|d|c|z)trmm: fixed it [ToDo] + Close ROCm/rocBLAS#1265 as erroneous + Remove HIP_UNSUPPORTED mark from hipblas(S|D|C|Z)trmm functions after merging ROCm/hipBLAS#504 + Add cublas2rocblas and update cublas2hipblas synthetic tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[IMP]
rocblas_(s|d|c|z)trmm_outofplace, as supported only for TRMM v2 CUDA analogues (HIP_SUPPORTED_V2_ONLY- works for roc* APIs as well)hipblas(S|D|C|Z)trmmasHIP_UNSUPPORTED[Reasons]
hipblas(S|D|C|Z)trmm, actually, do not match neither cublas TRMM functions, nor cublas TRMM _v2 functions: [5.3.X] TRMM functions do not have correct correspondence in hipBLAS hipBLAS#524cublas(S|D|C|Z)trmmand rocBLAS TRMMrocblas_(s|d|c|z)trmm_outofplace, notrocblas_(s|d|c|z)trmm: fixed it[ToDo]
HIP_UNSUPPORTEDmark fromhipblas(S|D|C|Z)trmmfunctions after merging hipblasTrmm API change to allow inplace and outofplace behaviour hipBLAS#504cublas2rocblasand updatecublas2hipblassynthetic tests