[HIPIFY][SWDEV-390802][build][fix] Hipify scripts and binary path updated in hipify-clang.txt #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdated in hipify-clang.txt As part of SWDEV-368821, the scripts and binaries will get installed under <Install_Prefix>/bin folder But the packaging txt file is referring the old path <Install_Prefix>. Corrected the same. CMAKE_INSTALL_PREFIX is used by default if the DESTINATION is a relative path. Changed the DESTINATION to relative path
emankov
reviewed
Mar 28, 2023
|
|
||
| install(TARGETS hipify-clang DESTINATION ${CMAKE_INSTALL_PREFIX}/bin) | ||
| install(TARGETS hipify-clang DESTINATION bin) |
There was a problem hiding this comment.
Shouldn't it be
install(TARGETS hipify-clang DESTINATION $(HIPIFY_BIN_INSTALL_PATH))instead?
There was a problem hiding this comment.
By default ${CMAKE_INSTALL_PREFIX} will be added to install command DESTINATION, if the path is relative(ex: bin)
Better to use relative path in destination , rather than absolute path
https://cmake.org/cmake/help/latest/command/install.html
emankov
added
fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of SWDEV-368821, the scripts and binary will get installed under <Install_Prefix>/bin folder But the packaging txt file is referring the old path <Install_Prefix>. Corrected the same.
CMAKE_INSTALL_PREFIX is used by default if the DESTINATION is a relative path. Changed the DESTINATION to relative path