Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HIPIFY][#584][DNN][MIOpen] cuDNN -> MIOpen - Part 12 - cuDNN LRN functions #826

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

emankov
Copy link
Collaborator

@emankov emankov commented Apr 4, 2023

  • Continued supporting hipification to MIOpen based on miopen.h
  • Updated the synthetic test cudnn2miopen.cu accordingly
  • [IMP] cudnnLRNCrossChannelForward and cudnnLRNCrossChannelBackward do not have a correspondence to miopenLRNForward and miopenLRNBackward - to discuss with the team

[ToDo]

  • [feature] Add a new type of transformation by declaring a var before the function call to add that var reference as an arg to the below function call
  • Add a reference to miopenLRNMode_t as a 2nd arg for miopenGetLRNDescriptor function call

… functions

+ Continued supporting hipification to MIOpen based on `miopen.h`
+ Updated the synthetic test `cudnn2miopen.cu` accordingly
+ [IMP] `cudnnLRNCrossChannelForward` and `cudnnLRNCrossChannelBackward` do not have a correspondence to `miopenLRNForward` and `miopenLRNBackward` - to discuss with the team

[ToDo]
+ [feature] Add a new type of transformation with declaring a var before the function call to add that var reference as an arg to the below function call
+ Add a referrence to miopenLRNMode_t as a 2nd arg for `miopenGetLRNDescriptor` function call
@emankov emankov added feature Feature request or implementation sync Syncing update DNN DNN related MIOpen labels Apr 4, 2023
@emankov emankov requested a review from searlmc1 April 4, 2023 10:16
@emankov emankov self-assigned this Apr 4, 2023
@emankov emankov merged commit 9681409 into ROCm:amd-staging Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DNN DNN related feature Feature request or implementation MIOpen sync Syncing update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant