Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location of half.hpp #2672

Closed
trixirt opened this issue Jan 12, 2024 · 3 comments
Closed

Location of half.hpp #2672

trixirt opened this issue Jan 12, 2024 · 3 comments

Comments

@trixirt
Copy link

trixirt commented Jan 12, 2024

On the rocm-6.0.0 tag on Fedora Rawhide and gfx90a

There are many build errors similar to
MIOpen/test/serialize.hpp:33:10: fatal error: 'half/half.hpp' file not found
33 | #include <half/half.hpp>
| ^~~~~~~~~~~~~~~

On Fedora half.hpp is part of the system supplied headers and is installed to the system's /usr/include
Adding the half/ to the path makes it impossible to correct.
The location of half.hpp should be determined in the cmake infra and added as a -I
and just include <half.hpp>

@atamazov
Copy link
Contributor

@trixirt Have you successfully installed the dependencies as specified at https://github.com/ROCm/MIOpen#installing-the-dependencies?

Do you use CMAKE_PREFIX_PATH as shown at https://github.com/ROCm/MIOpen#for-the-hip-backend-rocm-35-and-later-run?

@trixirt
Copy link
Author

trixirt commented Jan 16, 2024

I am packaging MIOpen with the Fedora dependencies for Fedora.
The ROCm packages in Fedora are tracked here Fedora Heterogeneous Compute Sig

To be packaged in Fedora MIOpen must be packaged with the Fedora dependencies.

@ppanchad-amd
Copy link

@trixirt Were you able to resolve your issue? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants