-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Documentation]: Inconsistent install instructions for ROCm/bitsandbytes
#3132
Comments
Hi Garrett, The instructions in the blog will be updated shortly. In the meantime, the recommended installation for bitsandbytes for ROCm is as follows:
|
Hi @garrettbyrd , Thanks for bringing it to our attention. There were lot of updates in the last few weeks which made those instructions obsolete. All the branches are updated now with latest instructions. |
@garrettbyrd Please advise if we can go ahead and close the ticket. Thanks! |
This is @garrettbyrd using my personal account. I was not able to reproduce. The package is able to build and is successfully added to my conda environment, but errors occur at runtime. I set up a fresh conda env as follows:
I set up an example notebook with two cells.
First cell output:
Second cell:
Second cell output:
This is consistent with some testing I was doing on another system with basically identical (but anecdotal) conditions. I also get the same output when wrapping with Here is the output of
It seems that GCC 13.2 is required (see mentions of Minor note: this hunch did not work with a simple |
@garrdbyrd , could you please build with this dockerfile and check? |
Description of errors
There are some recent blog posts [1,2,3] that provide the following install instructions for
ROCm/bitsandbytes
for ROCm v6.x:One can easily verify that the
rocm_enabled
branch does not include aMakefile
.In the README for this branch, it does provide the following instructions for installing
ROCm/bitsandbytes
:These instructions seem to work.
However, in the README for the branch
rocm6.2_internal_testing
, the same incorrect install steps are provided forROCm/bitsandbytes
:The same incorrect instructions are in the README for the branch
rocm5.7_internal_testing
.The branch
rocm6.2_internal_testing
needs to be corrected to have the following install instructions:And the branch
rocm5.7_internal_testing
needs to be corrected to have the following install instructionsThis would provide working, consistent install instructions between the three branches
rocm5.7_internal_testing
,rocm6.2_internal_testing
, androcm_enabled
.Other branches might have incorrect instructions, but I have not checked branches besides these three.
[1] https://rocm.blogs.amd.com/artificial-intelligence/starcoder-fine-tune/README.html
[2] https://rocm.blogs.amd.com/artificial-intelligence/llama2-Qlora/README.html
[3] https://rocm.blogs.amd.com/artificial-intelligence/llama2-lora/README.html
The text was updated successfully, but these errors were encountered: