Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add % of peak values to block-level speed-of-light charts #140

Closed
skyreflectedinmirrors opened this issue Jun 16, 2023 · 4 comments
Closed

Add % of peak values to block-level speed-of-light charts #140

skyreflectedinmirrors opened this issue Jun 16, 2023 · 4 comments
Assignees
@JoseSantosAMD
Labels
enhancement New feature or request metric definition Related to the definition of a metric in Omniperf
Milestone
v.1.0.9

Comments

@skyreflectedinmirrors
Copy link
Contributor

This was brought up in a demo today. Would improve consistency.
@coleramos425 coleramos425 self-assigned this Jun 21, 2023
@coleramos425 coleramos425 added this to the v.1.1.0 milestone Jun 21, 2023
@coleramos425 coleramos425 added enhancement New feature or request metric definition Related to the definition of a metric in Omniperf labels Jul 7, 2023
@JoseSantosAMD JoseSantosAMD mentioned this issue Jul 11, 2023
Closed
@JoseSantosAMD
Copy link
Contributor

@arghdos Added percent to the units in the CLI charts to be more consistent with the % units in the Speed-of-Light charts in the GUI. Is this what you meant?

@skyreflectedinmirrors
Copy link
Contributor Author

... sort of, the original ask was to add a % of Peak to appropriate metrics inside of the block-level SOL tables, so e.g., the Instruction Cache bandwidth as a percent of theoretically achievable peak. Your PR is a decent start, but I'm a bit wary of some of these, e.g.:

image

appears to be in % of Peak form (I haven't specifically verified it), but isn't labeled as such

@JoseSantosAMD
Copy link
Contributor

image
Like this?

@coleramos425 coleramos425 mentioned this issue Aug 15, 2023
Merged
@coleramos425
Copy link
Collaborator

Implemented. Thanks for closing this, Jose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoseSantosAMD JoseSantosAMD

Labels
enhancement New feature or request metric definition Related to the definition of a metric in Omniperf
Projects
None yet
Milestone
v.1.0.9
Development

No branches or pull requests
3 participants
@skyreflectedinmirrors @coleramos425 @JoseSantosAMD