Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

None of instruction mix panels contain min/max/avg breakdown across dispatches #154

Closed
skyreflectedinmirrors opened this issue Jul 21, 2023 · 2 comments
Closed

None of instruction mix panels contain min/max/avg breakdown across dispatches #154

skyreflectedinmirrors opened this issue Jul 21, 2023 · 2 comments
Assignees
@JoseSantosAMD
Milestone
v.1.0.9

Comments

@skyreflectedinmirrors
Copy link
Contributor

E.g.,:

https://github.com/AMDResearch/omniperf/blob/6487ba3853deaf97a91e03c0dc4d8a8109099546/src/omniperf_analyze/configs/gfx90a/1000_compute-unit-instruction-mix.yaml#L24

image

This is just implicitly giving you an average over all selected dispatches, which is pretty different from all the other tables.
@skyreflectedinmirrors
Copy link
Contributor Author

Same issue exists for the compute pipeline SOL:

https://github.com/AMDResearch/omniperf/blob/ed31b8a988b0fde6a5e11bc949417c82c6db1abc/src/omniperf_analyze/configs/gfx90a/1100_compute-unit-compute-pipeline.yaml#L20

@coleramos425 coleramos425 added this to the v.1.1.0 milestone Jul 31, 2023
@coleramos425 coleramos425 modified the milestones: v.1.0.9, v1.1.0 Aug 16, 2023
@coleramos425 coleramos425 mentioned this issue Aug 17, 2023
Merged
@coleramos425 coleramos425 modified the milestones: v1.1.0, v.1.0.9 Aug 17, 2023
@coleramos425
Copy link
Collaborator

Implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoseSantosAMD JoseSantosAMD

Labels
None yet
Projects
None yet
Milestone
v.1.0.9
Development

No branches or pull requests
3 participants
@skyreflectedinmirrors @coleramos425 @JoseSantosAMD