Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD that spans ALL modes #179

Closed
coleramos425 opened this issue Aug 25, 2023 · 2 comments
Closed

CI/CD that spans ALL modes #179

coleramos425 opened this issue Aug 25, 2023 · 2 comments
Assignees
Labels
Omniperf Revamp Ticket related to the redesign of Omniperf
Milestone

Comments

@coleramos425
Copy link
Collaborator

Describe the suggestion
CI/CD that spans ALL modes in Omniperf. Obtaining access to test nodes with Instinct cards that can be used in this pipeline.

Justification
At the moment CI/CD is incomplete in Omniperf - it only covers a handful of analyze mode command combinations. Without access to hardware to test Omniperf's profiling capabilities, profile mode is completely overlooked. If we obtain access to a test node, our code coverage would increase tremendously.

Additionally, there may be some room to re-think the procedure for the test cases we add/cover. At the moment, I don't think there's much of a methodology to the random list of command combinations tested.
(i.e. Adding testing for --gui flag, checking values of output tables between runs, etc.)

Implementation

  1. Steal an HPC Fund node from Karl
  2. Access what hardware we can spare for this "testing node"
  3. Some level of IT required to establish connection between workflow files and HPC Fund
  4. Come to an agreement on how list of test cases will be generated

Additional Notes
May want to loop @JoseSantosAMD into this as he's the engineer who set existing CI/CD up

Originally posted by @coleramos425 in #153 (comment)

@coleramos425 coleramos425 added the Omniperf Revamp Ticket related to the redesign of Omniperf label Aug 25, 2023
@coleramos425 coleramos425 added this to the v1.2.0 milestone Aug 25, 2023
@coleramos425
Copy link
Collaborator Author

coleramos425 commented Sep 14, 2023

TODO:

  • An Excel spreadsheet breaking down a testing matrix

  • Should include columns for mode, SoC, name of test, and arguments

  • Add column for "Expected Behavior"

  • Agree on what behavior should is to be monitored to warrant a passing mark

  • Add column for "Test Apps" to above table

  • Set an implementation plan

  • How can we encapsulate code to keep things clean/maintainable

  • Separating different testing into different files

@JoseSantosAMD JoseSantosAMD mentioned this issue Oct 25, 2023
@coleramos425
Copy link
Collaborator Author

Complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Omniperf Revamp Ticket related to the redesign of Omniperf
Projects
None yet
Development

No branches or pull requests

2 participants