Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--kernelVerbose overwrites full kernel names in omniperf profile and analyze #193

Closed
IanBogle opened this issue Oct 26, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@IanBogle
Copy link

Describe the bug
The --kernelVerbose flag overwrites full kernel names generated by rocprof. In the profile step, this results in having to add an argument to be able to analyze with full kernel names, but omniperf analyze also accepts and respects --kernelVerbose and results in overwriting the file containing kernel names. It seems the only way to recover the longer names is to re-run omniperf profile with the appropriate level of --kernelVerbose.

Development Environment:

  • Linux Distribution: Various
  • Omniperf Version: 1.0.10, 1.1.0-PR1
  • GPU: MI200
  • Cluster (if applicable): Thera

To Reproduce
Steps to reproduce the behavior:
tar -xzvf omniperf_verbose_repro.tar.gz
cd omniperf_verbose_repro
git clone git@github.com:kokkos/kokkos.git
cd build
./build.sh
make -j64
omniperf profile -n kokkos_dot --kernelVerbose=5 -- ./dot
omniperf analyze -p workloads/kokkos_dot/mi200 --list-kernels
(see full-length kernel names)
omniperf analyze -p workloads/kokkos_dot/mi200 --kernelVerbose=1 --list-kernels
(see shortened kernel names)
omniperf analyze -p workloads/kokkos_dot/mi200 --kernelVerbose=5 --list-kernels
(see shortened kernel names, instead of full-length kernel names)

Expected behavior
Since omniperf analyze already respects the --kernelVerbose argument, the shortened kernel names should be stored in a copy of the csv that holds the full kernel names. This way, omniperf profile will return full kernel names and shortened kernel names by default, and omniperf analyze can interpret the --kernelVerbose argument to find the file with the appropriate level of shortening (or create it if necessary).

More generally, the full profiling data obtained from rocprof shouldn't be modified by omniperf analyze. Any modifications to the data should be made in such a way that the change can be reverted.

Additional context
omniperf_verbose_repro.tar.gz

@IanBogle IanBogle added the bug Something isn't working label Oct 26, 2023
@coleramos425
Copy link
Collaborator

Closed in #303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants