Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create one roofline plot per kernel #93

Closed
gmarkomanolis opened this issue Feb 23, 2023 · 3 comments
Closed

Create one roofline plot per kernel #93

gmarkomanolis opened this issue Feb 23, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request Roofline Related to Omniperf's Roofline Analysis

Comments

@gmarkomanolis
Copy link

When we execute omniperf with could we have except a roofline plot with all the kernels and one plot per kernel? When we have the plot with all the kernels, we do not know the names. Just to add motivation to my request, imagine we have blocked the --gui and there is no grafana and we would like to see rooflines for the top 10 kernels, so we can have 10 PDFs, name the PDF the kernel name or whatever you prefer and we can see the roofline of each kernel. At least this will help a bit until the other issue gets fixed with the roofline and filtering the kernels.

@coleramos425 coleramos425 added enhancement New feature or request Roofline Related to Omniperf's Roofline Analysis labels Feb 23, 2023
@coleramos425
Copy link
Collaborator

coleramos425 commented Feb 23, 2023

@gmarkomanolis I can understand the use case you are describing, but generating 10 plots (x2 for each dtype) seems a bit excessive.

Perhaps a new optional like --kernel-names could change each AI point in the graph to a different shape. Then a legend could be provided to identify each kernel based on its shape. Here only one graph would be needed...
image

@gmarkomanolis
Copy link
Author

If it is easy to map the kernel name to the data point while reading the plot, it is ok.

@coleramos425
Copy link
Collaborator

See Omniperf/kernel-names branch for initial implementation.

You can now run Omniperf with --kernel-names to activate this functionality. i.e.

$ omniperf profile -n dummy --roof-only --kernel-names -- <app_cmd>

@coleramos425 coleramos425 self-assigned this Mar 6, 2023
@coleramos425 coleramos425 added this to the v1.0.8 milestone Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Roofline Related to Omniperf's Roofline Analysis
Projects
None yet
Development

No branches or pull requests

2 participants