Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix roofline calculation for single dispatch #97

Closed
coleramos425 opened this issue Mar 13, 2023 · 1 comment
Closed

Fix roofline calculation for single dispatch #97

coleramos425 opened this issue Mar 13, 2023 · 1 comment
Assignees
@coleramos425
Labels
bug Something isn't working Roofline Related to Omniperf's Roofline Analysis

Comments

@coleramos425
Copy link
Collaborator

As pointed out my an Omniperf user. An issue with roofline calculation arrises in a workload with a single dispatch.
https://github.com/AMDResearch/omniperf/blob/0705db024c184bb8b99e64eea36b1cf36c062e0a/src/omniperf_analyze/utils/roofline_calc.py#L211-L221
Such that, a single dispatch is overlooked in for-loop logic. This code requires adjustment.
@coleramos425 coleramos425 added bug Something isn't working Roofline Related to Omniperf's Roofline Analysis labels Mar 13, 2023
@coleramos425 coleramos425 self-assigned this Mar 13, 2023
@coleramos425 coleramos425 mentioned this issue Mar 13, 2023
Merged
@coleramos425 coleramos425 added this to the v1.0.8 milestone Mar 13, 2023
@coleramos425
Copy link
Collaborator Author

Fix implemented and merged into main. Closing ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coleramos425 coleramos425

Labels
bug Something isn't working Roofline Related to Omniperf's Roofline Analysis
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@coleramos425