Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some hipBLAS documentation updates. #633

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

daineAMD
Copy link
Contributor

There's plenty of work to do to improve hipBLAS documentation. Would be good to have it as good as the rocBLAS documentation since it's likely to be used by more general users. This is just an incremental improvement prompted by LWPMLSE-463. Will add documentation regarding atomics after this goes in.

@daineAMD daineAMD added the noCI Disable Jenkins for this PR. label Jul 14, 2023
Copy link
Contributor

@TorreZuk TorreZuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start. If matches general pattern of rocblas may be simpler to maintain.

Comment on lines 31 to 32
- Big case for matrix, e.g. matrix A, B, C GEMM (C = A*B)
- Lower case for vector, e.g. vector x, y GEMV (y = A*x)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upper case ...

@daineAMD daineAMD merged commit 6042a05 into ROCm:develop Jul 17, 2023
2 of 3 checks passed
@daineAMD daineAMD deleted the atomics-documentation branch July 17, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
noCI Disable Jenkins for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants