Deprecating hipblasComplex types and adding _v2 version of ixamax #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daineAMD
requested review from
amcamd,
TorreZuk,
mahmoodw,
bragadeesh,
NaveenElumalaiAMD and
rkamd
as code owners
TorreZuk
approved these changes
Aug 10, 2023
| } | ||
| else | ||
| { | ||
| EXPECT_EQ(HIPBLAS_STATUS_SUCCESS, status); // fail |
There was a problem hiding this comment.
All the // fail comments not really sure of.
There was a problem hiding this comment.
Yeah, that line just ensures that we actually get a gtest failure when we don't get HIPBLAS_STATUS_SUCCESS from testing_*.hpp. // fail is meant to imply that if we get to that line, the test will fail. hipBLAS gtest framework needs some rework.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beginning of deprecation of hipblas complex types. Just made changes for ixamax for now, please let me know if you had something else in mind for this process.