New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows toolchain #658

Merged

TorreZuk merged 2 commits into ROCm:develop from TorreZuk:windows-toolchain

Aug 15, 2023

Contributor

TorreZuk commented Aug 14, 2023

updates to match rocblas conventions and avoid duplicating compiler flags

TorreZuk added 2 commits

August 14, 2023 09:46


          match rocblas windows toolchain

17eb8ad


          avoid duplicate flags from toolchain var append

6ae4a6b

TorreZuk requested review from amcamd, mahmoodw, daineAMD, bragadeesh, NaveenElumalaiAMD and rkamd as code owners

August 14, 2023 22:19

Contributor Author

TorreZuk commented Aug 15, 2023

Only affects windows which passed, the linux failures look to be stale dependencies

daineAMD approved these changes

View reviewed changes

TorreZuk merged commit a1d0936 into ROCm:develop

13 of 19 checks passed

TorreZuk deleted the windows-toolchain branch

August 15, 2023 15:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

daineAMD daineAMD approved these changes

amcamd Awaiting requested review from amcamd amcamd is a code owner

mahmoodw Awaiting requested review from mahmoodw mahmoodw is a code owner

bragadeesh Awaiting requested review from bragadeesh bragadeesh is a code owner

NaveenElumalaiAMD Awaiting requested review from NaveenElumalaiAMD NaveenElumalaiAMD is a code owner

rkamd Awaiting requested review from rkamd rkamd is a code owner