Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge yaml hotfix from develop to release-staging/rocm-rel-6.0 #675

Conversation

daineAMD
Copy link
Contributor

git merge --ff-only develop into release-staging/rocm-rel-6.0. Really only need b875c52 but thought this ff merge would be cleaner since other changes are mainly just CI updates.

dependabot bot and others added 7 commits September 1, 2023 08:46
* Bump rocm-docs-core from 0.20.0 to 0.21.0 in /docs/.sphinx

Bumps [rocm-docs-core](https://github.com/RadeonOpenCompute/rocm-docs-core) from 0.20.0 to 0.21.0.
- [Release notes](https://github.com/RadeonOpenCompute/rocm-docs-core/releases)
- [Changelog](https://github.com/RadeonOpenCompute/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v0.20.0...v0.21.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* replace noCI label with ci:docs-only

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sam Wu <sam.wu2@amd.com>
Bumps [rocm-docs-core](https://github.com/RadeonOpenCompute/rocm-docs-core) from 0.21.0 to 0.22.0.
- [Release notes](https://github.com/RadeonOpenCompute/rocm-docs-core/releases)
- [Changelog](https://github.com/RadeonOpenCompute/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v0.21.0...v0.22.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [gitpython](https://github.com/gitpython-developers/GitPython) from 3.1.32 to 3.1.34.
- [Release notes](https://github.com/gitpython-developers/GitPython/releases)
- [Changelog](https://github.com/gitpython-developers/GitPython/blob/main/CHANGES)
- [Commits](gitpython-developers/GitPython@3.1.32...3.1.34)

---
updated-dependencies:
- dependency-name: gitpython
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [gitpython](https://github.com/gitpython-developers/GitPython) from 3.1.34 to 3.1.35.
- [Release notes](https://github.com/gitpython-developers/GitPython/releases)
- [Changelog](https://github.com/gitpython-developers/GitPython/blob/main/CHANGES)
- [Commits](gitpython-developers/GitPython@3.1.34...3.1.35)

---
updated-dependencies:
- dependency-name: gitpython
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Copy link
Contributor

@TorreZuk TorreZuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Yes I would ffwd as long as you are allowed and not for 6.1. Would have thought you could have used staging as the source were things commits not there yet? Is develop to staging promotion turned off?

@daineAMD
Copy link
Contributor Author

LGTM. Yes I would ffwd as long as you are allowed and not for 6.1. Would have thought you could have used staging as the source were things commits not there yet? Is develop to staging promotion turned off?

I think the ff to staging is on. I just merged the last develop PR a few minutes ago so staging should be updated soon.

@amcamd
Copy link
Contributor

amcamd commented Sep 14, 2023

For --ff-only merges usually I do it manually without a PR. If release-staging/rocm-rel-6.0 is only ahead (no commits behind) the branch this is coming from I think a "rebase and merge" may do the same thing.

@amcamd
Copy link
Contributor

amcamd commented Sep 15, 2023

Looking at the commits in release-staging/rocm-rel-6.0 and the commits in this PR, a rebase and merge for this PR should be the same as --ff-only merging staging into release-staging/rocm-rel-6.0. Please rebase and merge this PR.

@daineAMD daineAMD merged commit 1f12b16 into ROCm:release-staging/rocm-rel-6.0 Sep 15, 2023
21 of 24 checks passed
@daineAMD daineAMD deleted the release-staging/rocm-rel-6.0 branch September 27, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants