Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update CHANGELOG.md for ROCm 5.7 #682

Merged
merged 3 commits into from
Sep 25, 2023
Merged

update CHANGELOG.md for ROCm 5.7 #682

merged 3 commits into from
Sep 25, 2023

Conversation

amcamd
Copy link
Contributor

@amcamd amcamd commented Sep 23, 2023

  • This will be merged into release-staging/rocm-rel-6.0 at FC2
  • We will remove the (unreleased) for rocBLAS 4.0.0 at FC3 (the final FC for ROCm 6.0)

TorreZuk
TorreZuk reviewed Sep 25, 2023
View reviewed changes
CHANGELOG.md Outdated
Comment on lines 4 to 6
### Deprecated
- hipblasDatatype_t is removed and replaced with hipDataType
- hipblasComplex and hipblasDoubleComplex are removed and replaced with hipComplex and hipDoubleComplex
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wording is not clear to me. Either it is deprecated in this version or it is removed. These deprecated ones should be "are to be removed and can be ...". Would be nice to detail how to use the new/old API for these cases in a bit more detail.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, improved wording to for deprecated datatypes.

daineAMD
daineAMD approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@daineAMD daineAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Andrew!

@amcamd amcamd merged commit 837b218 into ROCm:develop Sep 25, 2023
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TorreZuk TorreZuk TorreZuk left review comments

@daineAMD daineAMD daineAMD approved these changes

@mahmoodw mahmoodw Awaiting requested review from mahmoodw mahmoodw is a code owner

@bragadeesh bragadeesh Awaiting requested review from bragadeesh bragadeesh is a code owner

@NaveenElumalaiAMD NaveenElumalaiAMD Awaiting requested review from NaveenElumalaiAMD NaveenElumalaiAMD is a code owner

@rkamd rkamd Awaiting requested review from rkamd rkamd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amcamd @TorreZuk @daineAMD