Change some L2 apis to use 'n' instead of 'm' where applicable #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daineAMD
requested review from
amcamd,
TorreZuk,
mahmoodw,
bragadeesh,
NaveenElumalaiAMD and
rkamd
as code owners
TorreZuk
approved these changes
Sep 28, 2023
Yeah consistency with both legacy blas and cuBLAS. Would be good to have rocBLAS match too but not important, just something I stumbled across. |
|
Looks like CI might not be enabled for cuda pipeline for develop-6.1 PRs. Ran manually on cuda machine and built successfully and passed all blas2 tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing some L2 functions (with triangular and symmetric matrices) to use
nin signature for size instead ofmto match legacy blas.