Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename 'aux' dirs to 'auxil' #720

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Rename 'aux' dirs to 'auxil' #720

merged 1 commit into from
Nov 21, 2023

Conversation

daineAMD
Copy link
Contributor

TorreZuk
TorreZuk approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@TorreZuk TorreZuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay but I think I don't like auxil either, not sure why though :-)

@daineAMD
Copy link
Contributor Author

Okay but I think I don't like auxil either, not sure why though :-)

Any preference on another name? 'misc', 'auxiliary', 'other', 'blas_aux', 'blas0'? We don't have these folders in rocblas

@TorreZuk
Copy link
Contributor

Okay but I think I don't like auxil either, not sure why though :-)

Any preference on another name? 'misc', 'auxiliary', 'other', 'blas_aux', 'blas0'? We don't have these folders in rocblas

It is fine. Etymology fits it

amcamd
amcamd approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@amcamd amcamd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good thing aux and auxil occur in auxiliary and not any other word I can find.

@TorreZuk
Copy link
Contributor

I think that it built may be enough results to merge. The test looks like some connection failure so can just review the next develop test run

@daineAMD daineAMD merged commit fd2c644 into ROCm:develop Nov 21, 2023
18 of 24 checks passed
@daineAMD daineAMD deleted the rem-aux branch November 21, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amcamd amcamd amcamd approved these changes

@TorreZuk TorreZuk TorreZuk approved these changes

@mahmoodw mahmoodw Awaiting requested review from mahmoodw mahmoodw is a code owner

@bragadeesh bragadeesh Awaiting requested review from bragadeesh bragadeesh is a code owner

@NaveenElumalaiAMD NaveenElumalaiAMD Awaiting requested review from NaveenElumalaiAMD NaveenElumalaiAMD is a code owner

@rkamd rkamd Awaiting requested review from rkamd rkamd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@daineAMD @TorreZuk @amcamd