64-bit interface for L3 functions #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daineAMD
requested review from
amcamd,
TorreZuk,
mahmoodw,
bragadeesh,
NaveenElumalaiAMD,
rkamd and
a team
as code owners
NaveenElumalaiAMD
approved these changes
Apr 23, 2024
clients/gtest/blas3/trtri_gtest.yaml
Outdated
| @@ -17,7 +17,7 @@ Tests: | |||
| uplo: [ 'L', 'U' ] | |||
| diag: [ 'N', 'U' ] | |||
| matrix_size: *size_range | |||
| api: [ FORTRAN, C ] | |||
| api: [ FORTRAN, C , FORTRAN_64, C_64] | |||
There was a problem hiding this comment.
trtri ILP64 rocBLAS is not done right? If that is the case could we comment this just like other functions?
There was a problem hiding this comment.
Good catch, I've removed this. Didn't make other changes for trtri since I'm not sure if we're planning on 64-bit support for it or not.
amcamd
reviewed
Apr 24, 2024
| beta, | ||
| dC, | ||
| ldc)); | ||
| // DAPI_EXPECT(HIPBLAS_STATUS_INVALID_VALUE, |
There was a problem hiding this comment.
Should the commented out code be removed?
There was a problem hiding this comment.
uncommented it and moved into if(arg.bad_arg_all) since cuBLAS documentation is unclear on whether or not this is supported.
amcamd
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the giant PR. This adds the interfaces needed for 64-bit support for all L3 functions (with the exception of trtri). It adds rocBLAS backend support for dgmm, trmm, and trsm, and will need fairly minimal changes to include the other functions as they are added to rocBLAS.