Fixed hang in test_hipcub_grid on gfx1030 #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfep
force-pushed
the
fix-grid-barrier-hang-gfx1030
branch
from
4472b87
to
553855d
Compare
stanleytsang-amd
approved these changes
Feb 8, 2022
stanleytsang-amd
pushed a commit
that referenced
this pull request
Mar 4, 2022
stanleytsang-amd
added a commit
that referenced
this pull request
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grid_barrierusesthread_loadfor loading values from global memory.thread_loadwas previously implemented with two inline assembly statements. This gave opportunity to the compiler to inject instructions between the two, in our case it injected the comparison before thes_waitcnt.