Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build gemm-tune only in tensile builds #1317

Merged
merged 1 commit into from
May 30, 2023
Merged

build gemm-tune only in tensile builds #1317

merged 1 commit into from
May 30, 2023

Conversation

TorreZuk
Copy link
Contributor

  • allows no tensile build

daineAMD
daineAMD approved these changes May 29, 2023
View reviewed changes
Copy link
Contributor

@daineAMD daineAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I can try a local build if you're looking for more testing.

@TorreZuk
Copy link
Contributor Author

Well I built once, if you need it no-tensile locally you can cherry-pick. I will make develop PR to test tomorrow if you get your hipblas PR done.

@TorreZuk TorreZuk merged commit 4c003ee into release-staging/rocm-rel-5.7 May 30, 2023
@TorreZuk TorreZuk deleted the hofix-build-gemm-tune-tensile-only branch May 30, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielenventer nielenventer nielenventer approved these changes

@daineAMD daineAMD daineAMD approved these changes

@amcamd amcamd Awaiting requested review from amcamd amcamd is a code owner

@mahmoodw mahmoodw Awaiting requested review from mahmoodw mahmoodw is a code owner

@bragadeesh bragadeesh Awaiting requested review from bragadeesh bragadeesh is a code owner

@NaveenElumalaiAMD NaveenElumalaiAMD Awaiting requested review from NaveenElumalaiAMD NaveenElumalaiAMD is a code owner

@rkamd rkamd Awaiting requested review from rkamd rkamd is a code owner

@yoichiyoshida yoichiyoshida Awaiting requested review from yoichiyoshida yoichiyoshida is a code owner

@babakpst babakpst Awaiting requested review from babakpst babakpst is a code owner

@nakajee nakajee Awaiting requested review from nakajee nakajee is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TorreZuk @nielenventer @daineAMD