-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix guard kernel launches #1364
Hotfix guard kernel launches #1364
Conversation
TorreZuk
commented
Oct 17, 2023
- cherry picks guard most kernel GGL launches (#2087)](b281770)
- macro looks at hipPeekAtLastError to determine async kernel launch only status
- new code pattern in that all kernel launch functions return status
* guard kernel GGL launches and different before and after peekAtLastHipError cause rocblas failure status * log these hip errors to rocblas_cerr as causing failure status
Can you add a section to the file docs/API_Reference_Guide.rst after the section Kernel launch status error checking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested additional documentation.
Okay can add something like that. I think it checks thread limits but not work item limits. The other launch styles check max workgroups. But 0 work groups is checked. ... the pre-existing error may not be from a kernel launch, but for it to match errors may be very unlikely |
OK, it will be best to list only some of the things it is known to check (We do not want to claim it checks something we do not know it checks, and we do not want to document hipPeakLastError() . We do not document what we do not implement :) |
You can review last commit |