Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change xnack to off #148

Merged
merged 5 commits into from Oct 16, 2020
Merged

Change xnack to off #148

merged 5 commits into from Oct 16, 2020

Conversation

eidenyoshida
Copy link
Collaborator

No description provided.

@doctorcolinsmith
Copy link
Collaborator

As a sanity check, we're looking for xnack on and off, which produces kernels. The any mode produces a single kernel that works in both modes.

@saadrahim saadrahim changed the title Change xnack to ANY Change xnack to off Oct 15, 2020
@saadrahim
Copy link
Member

I thought we are just merging in changes to default to xnack off.

@saadrahim saadrahim merged commit 983f9fc into develop Oct 16, 2020
@ax3l
Copy link

ax3l commented Oct 17, 2020

@ eidenyoshida @saadrahim

I think this PR caused a regression in our CI, building rocRAND like this:

mkdir build
cd build
cmake .. -DCMAKE_CXX_COMPILER=$(which hipcc)

and does not build anymore with:

[ 60%] Building CXX object library/CMakeFiles/rocrand.dir/src/rocrand.cpp.o
clang-11: error: Unsupported CUDA gpu architecture: gfx900:xnack-
clang-11: error: Unsupported CUDA gpu architecture: gfx906:xnack-
clang-11: error: Unsupported CUDA gpu architecture: gfx908:xnack-

@ax3l ax3l mentioned this pull request Oct 17, 2020
5 tasks
@doctorcolinsmith
Copy link
Collaborator

@ax3l Thanks for reporting the regression. Until it is fixed, we recommend using the most recent released version instead of the master branch for a stable build.

Naraenda added a commit to StreamHPC/rocRAND that referenced this pull request Jun 13, 2023
…directionvectors64' into 'develop_stream'

Resolve "Implement curandGetDirectionVectors32 and curandGetDirectionVectors64"

Closes ROCm#148

See merge request amd/libraries/rocRAND!237
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants