New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECAU: Generic provider #305
Comments
On second though, I'm not sure whether this is a good idea. It'd rely on heuristics, which can be finnicky, and the image displayed on "Purchase for mail order" pages might not accurately represent a physical release. Also, the generic provider might work for providers which really need a special-purpose provider because they might have multiple images (e.g. DatPiff would work with the |
Another possibility which seems to work OK on ebay:
For the tree distance metric, there are a few options that I've tested and all of them seem like they'd work:
Another possibility might be to minimise the total number of nodes "between" the image and the h1 (including the size of any subtree that's between them). At least for ebay, which I've been experimenting on, simply taking the largest image won't work, since that'll select the logo. |
Could be useful for random "Purchase for mail order" URLs. Have it fetch the image found in the
og:image
meta property, if it exists.The text was updated successfully, but these errors were encountered: