Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable Chat Name Colors #658

Open
11 of 13 tasks
dmccoystephenson opened this issue Oct 15, 2023 · 4 comments
Open
11 of 13 tasks

Customizable Chat Name Colors #658

dmccoystephenson opened this issue Oct 15, 2023 · 4 comments
Assignees
Milestone

Comments

@dmccoystephenson
Copy link

dmccoystephenson commented Oct 15, 2023

Desired Solution

As a regular player, I should be able to change the color of my name when it appears in the chat. As an operator, I should be able to change the color of the name of any player when it appears in the chat. Changes to name colors should be immediate and persist upon a server restart.

A list of channels excluded from the profile color override should be configurable in the config.yml. In other words, operators should be capable of configuring some channels to not allow players to override the color of their name that appears in the chat.

Subtasks

  • Database Modifications
    Some new tables will be required to store the color of profile names.
  • Database Migrations
    Migrations will be necessary to bring old databases up to speed with the new database tables and any other changes that might have been made.
  • Chat Listener Modifications
    Chat listener(s) must be modified to use stored color for profiles if set.
  • User Configuration
    Players should be able to configure their profile name color.
  • Operator Configuration
    Operators should be able to configure the profile colors of any player.
  • Test RPKit Upgrade
    Functionality should be verified when upgrading RPKit from an old version that did not include the database changes to the new version with the database changes.

Acceptance Criteria

  • Database modified
  • Database migrations created
  • Colors used in chat listener(s)
  • Users can configure colors
  • Changes to chat name colors persist upon restarting the server
  • Operators can configure colors
  • RPKit doesn't break after upgrading
@alyphen alyphen added this to the v2.5.0 milestone Oct 16, 2023
@dmccoystephenson dmccoystephenson changed the title Customizable Chat Name Colors Customizable Profile Colors Nov 4, 2023
@dmccoystephenson dmccoystephenson changed the title Customizable Profile Colors Customizable Profile Name Colors Nov 4, 2023
@dmccoystephenson dmccoystephenson changed the title Customizable Profile Name Colors Customizable Chat Name Colors Nov 4, 2023
@dmccoystephenson
Copy link
Author

dmccoystephenson commented Nov 21, 2023

The branch for this work item can be found here:
https://github.com/dmccoystephenson/my-RPKit/tree/setchatnamecolor

(updated 3/27/2024)

@dmccoystephenson
Copy link
Author

I can verify that the migration for the new table works and that the 'chat_name_color' associated with a minecraft profile id can be inserted, updated & queried.

Next step is to actually use the 'chat_name_color' value when a message gets sent to a channel.

@dmccoystephenson
Copy link
Author

Added "Changes to chat name colors persist upon restarting the server" to the acceptance criteria

@dmccoystephenson
Copy link
Author

This may be considered a duplicate of #627

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants