(asar.dll) assemble error flag isn't reset

[boldowa]

This issue doesn't occur in exe

Overview

Once an compilation fails, subsequent compilation will not succeed.

steps	Assemble result	asar_patch() result	remarks
1	OK	true	errordata count is 0
2	NG	false	errordata count isn't 0
3	OK	false	errordata count is 0

In [3], the result of asar_patch() should be true.

Opinion

Since this is an error as a result of the whole assembly, it may be doing this on purpose.

However, I think that Asar shouldn't be judge it. That's the role of a tool that uses it.

Cause

interface-lib.cpp line: 16 - errored

Initialization processing of this variable exists only in asar_math(). Why

[boldowa]

There are 2 plans to fix it.

1. reset "errored" when asar_reset() called
2. reset "errored" before assemble

(Alternatively, do both of the above)

If the policy is decided, the modification will take only a few minutes.

[RPGHacker]

Thanks for the report. I'm currently setting up an environment for easily testing the Asar's DLL by running a bunch of patchs through it. I've actually encountered a bunch of bugs with it already, Once the test environment is there, I'll see if I can reproduce and fix this.

[RPGHacker]

Should be fixed with the latest commit. Can you sync and verify for me, please?

[boldowa]

I confirmed it.

OK, it seems to be working fine. 😃