Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(setup): attempt at making versioning work #5

Merged
merged 1 commit into from Nov 28, 2022
Merged

chore(setup): attempt at making versioning work #5

merged 1 commit into from Nov 28, 2022

Conversation

spifory
Copy link
Collaborator

@spifory spifory commented Nov 28, 2022

Rationale

Currently, auto-publishing does not work, due to a version error.

Summary of changes made

This pull request hopefully makes the CI work again, as it excludes the git commit hash from the version. Has not been tested.

Checklist

  • This PR changes the onami module/cog codebase
    • These changes add new functionality to the module/cog
    • These changes fix an issue or bug in the module/cog
    • I have tested that these changes work on a production bot codebase
    • I have tested these changes against the CI/CD test suite
    • I have updated the documentation to reflect these changes
  • This PR changes the CI/CD test suite
    • I have tested my suite changes are well-formed (all tests can be discovered)
    • These changes adjust existing test cases
    • These changes add new test cases
  • This PR changes prose (such as the documentation, README or other Markdown/RST documents)
    • I have proofread my changes for grammar and spelling issues
    • I have tested that any changes regarding Markdown/RST syntax result in a well formed document

@VincentRPS VincentRPS merged commit 0c7866c into VincentRPS:master Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants