Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand Asset class to support things other than Images #1346

Closed
cwisniew opened this issue Mar 3, 2020 · 5 comments
Closed

Expand Asset class to support things other than Images #1346

cwisniew opened this issue Mar 3, 2020 · 5 comments
Assignees
@cwisniew
Labels
claimed Issue is being actively worked on. feature Adding functionality that adds value
Projects
MapTool 1.11.0 Road Map

Comments

@cwisniew
Copy link
Member

cwisniew commented Mar 3, 2020 •
edited

The Asset class should be able to support multiple types of assets.
At the moment the Asset type is being used to store other unknown binary types for the Hero Lab support, but this should be expanded so that it can store things like text (and be aware its text/sound/etc).
@cwisniew cwisniew added the feature Adding functionality that adds value label Mar 3, 2020
@cwisniew cwisniew self-assigned this Mar 3, 2020
@cwisniew cwisniew mentioned this issue Mar 3, 2020
Closed
@JamzTheMan
Copy link
Member

FWIW this should probably include Asset Library for better integrations of file filter types. Or another issue?

It's only related in the sense that there are a lot of assumptions in the code that Assets should be an image type but currently it knows about .por and .PDF files and probably will/should know about other binaries like audio files as well.

@cwisniew cwisniew added the claimed Issue is being actively worked on. label Mar 3, 2020
@cwisniew
Copy link
Member Author

cwisniew commented Mar 3, 2020

FWIW this should probably include Asset Library for better integrations of file filter types. Or another issue?

Yeah already considered it, its part of #1348 and #1349

@cwisniew cwisniew mentioned this issue Mar 6, 2020
Closed
@bubblobill
Copy link
Collaborator

bubblobill commented Mar 19, 2020 •
edited

Using this would we be able to have snd: tokens in the same way we have img: tokens?

@Phergus
Copy link
Contributor

Phergus commented Mar 23, 2020

Yes. That's one of the goals.

@cwisniew cwisniew added this to the 2.0.0 milestone May 25, 2020
@cwisniew cwisniew added this to To do in MapTool 1.11.0 via automation Jun 18, 2021
@cwisniew cwisniew removed this from the 2.0.0 - Campaign Directories & Note Books milestone Sep 4, 2021
@cwisniew cwisniew added this to Future in Road Map via automation Oct 6, 2021
@cwisniew cwisniew moved this from Future to MapTool 1.11 in Road Map Oct 6, 2021
@cwisniew cwisniew mentioned this issue Oct 19, 2021
Merged
@cwisniew cwisniew mentioned this issue Nov 9, 2021
Merged
@Phergus Phergus moved this from To do to In progress in MapTool 1.11.0 Nov 10, 2021
@Phergus Phergus moved this from In progress to Needs Testing in MapTool 1.11.0 Nov 11, 2021
@Phergus
Copy link
Contributor

Phergus commented Nov 23, 2021

Foundational work completed.

@Phergus Phergus closed this as completed Nov 23, 2021
@Phergus Phergus moved this from Needs Testing to Reviewer approved in MapTool 1.11.0 Nov 23, 2021
@Phergus Phergus moved this from Reviewer approved to Done in MapTool 1.11.0 Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwisniew cwisniew

Labels
claimed Issue is being actively worked on. feature Adding functionality that adds value
Projects
Road Map
MapTool 1.11
MapTool 1.11.0
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cwisniew @JamzTheMan @Phergus @bubblobill