Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MapTool is registered as the default handler for *all* zip files #2432

Closed
duckinator opened this issue Mar 3, 2021 · 3 comments
Closed

MapTool is registered as the default handler for *all* zip files #2432

duckinator opened this issue Mar 3, 2021 · 3 comments
Assignees
Labels

Comments

@duckinator
Copy link
Contributor

Describe the bug
After #1856, MapTool is registered to open all zip files.

My understanding is it is related by the first line of packages/associations.properties:

mime-type=application/zip
extension=cmpgn
description=MapTool campaign save file

I believe, in theory, you could just remove the mime-type=application/zip line and it would be fine.

To Reproduce
Steps to reproduce the behavior:

  1. Install MapTool
  2. Open a zip file. (even with a .zip extension)

Expected behavior

I expected .zip files to open with something other than MapTool.

Screenshots
If applicable, add screenshots to help explain your problem.

MapTool Info

  • Version: 1.8.3
  • Install: New

Desktop (please complete the following information):

  • OS: Windows 10, Fedora 32 (Linux), Manjaro (Linux)

cc @kayila because we talked about this a bit

@duckinator duckinator added the bug label Mar 3, 2021
@Azhrei
Copy link
Member

Azhrei commented Mar 3, 2021

Agreed. According to https://docs.oracle.com/en/java/javase/14/jpackage/support-application-features.html#GUID-324F3A7B-409A-426D-AFB1-E4540049D13E it should be possible to remove the MIME type completely (or it should be changed to application/maptool or similar).

(If we're going to modify the build process, we should also add --linux-shortcut as Debian-based Linux users have indicated they're not getting a desktop shortcut created when they install MapTool.)

@Phergus Phergus added this to To do in MapTool 1.8.4 via automation Mar 4, 2021
@Phergus
Copy link
Contributor

Phergus commented Mar 6, 2021

@duckinator

I believe, in theory, you could just remove the mime-type=application/zip line and it would be fine.

Was thinking I'd just change it to mime-type=application/maptool to be in line with other application files.

@Azhrei

(If we're going to modify the build process, we should also add --linux-shortcut as Debian-based Linux users have indicated they're not getting a desktop shortcut created when they install MapTool.)

It already has it as well as the menu group designation.

installerOptions += [
	'--linux-menu-group', 'Game',
	'--linux-shortcut'
]

@Phergus Phergus self-assigned this Mar 6, 2021
@Phergus Phergus moved this from To do to In progress in MapTool 1.8.4 Mar 6, 2021
@perception101
Copy link

perception101 commented Mar 7, 2021

Caused quite a bit of havoc at my end, triggering Firefox to start saving zip files as file.zip.cmpgn and always try to open them in MapTool. Worth include a fix to 1.8.4 to back-out the incorrect association too?

@Phergus Phergus moved this from In progress to Review in progress in MapTool 1.8.4 Mar 11, 2021
@Phergus Phergus closed this as completed Mar 11, 2021
@Phergus Phergus moved this from Review in progress to Done in MapTool 1.8.4 Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

4 participants