<select> element with multiple attribute containing an <option> element prevents form from being submitted #2741

dark-ether · 2021-06-16T13:22:57Z

Describe the bug

a <select> element with the multiple attribute will, if it contains an <option></option>\ element, breaks the submit button which submits the form.

To Reproduce
Steps to reproduce the behavior:

in a new campaign create a token called Lib:test
in the Lib:test token create 2 macros called link and test
in the link macro copy and then paste [r:broadcast(macro.args)]
in the test macro copy and then paste

[h:link = macroLinkText("link@Lib:test","all")]

[frame5("test"):{

	<form action="[r:link]" method="json">
	
	<select id="test" name="test" multiple>
			<option value="option">option</option>
	</select><br/>
	
	<input name="submit" type="submit" value="sucess" name="submit">
	
	</form>
}]

click in the test macro and in the opened frame click the button

Expected behavior
after doing these steps a json element containing the key value pair submit:sucess should appear in chat

MapTool Info

Version: 1.9.0 and 1.9.2
Install: the Deb package

Desktop (please complete the following information):

OS: linux Pop! Os
Version 20.10

Additional context
submit buttons which submit other forms in the same frame still work

The text was updated successfully, but these errors were encountered:

kwvanderlinde · 2021-06-17T01:05:20Z

First of all, there are a couple of changes that should be made to your code:

Use the r option on the foreach so that it doesn't try print tooltips or anything.
Change the "link" macro to broadcast instead of roll:
```
[h: broadcast(macro.args)]
```
Otherwise the output won't make it to chat.

But even with those fixed, there is certainly an issue with multiple. I did some debugging on Linux Mint 20, and found that this line throws an exception. After adding a catch-all, this is what I found:

java.lang.UnsatisfiedLinkError: 'long com.sun.webkit.dom.HTMLOptionsCollectionImpl.itemImpl(long, int)'
	at javafx.web/com.sun.webkit.dom.HTMLOptionsCollectionImpl.itemImpl(Native Method)
	at javafx.web/com.sun.webkit.dom.HTMLOptionsCollectionImpl.item(HTMLOptionsCollectionImpl.java:88)
	at net.rptools.maptool.client.ui.htmlframe.HTMLWebViewManager.getDataAndSubmit(HTMLWebViewManager.java:622)
	at javafx.web/com.sun.webkit.dom.EventListenerImpl.fwkHandleEvent(EventListenerImpl.java:129)
	at javafx.web/com.sun.webkit.WebPage.twkProcessMouseEvent(Native Method)
	at javafx.web/com.sun.webkit.WebPage.dispatchMouseEvent(WebPage.java:813)
	at javafx.web/javafx.scene.web.WebView.processMouseEvent(WebView.java:1020)
	at javafx.web/javafx.scene.web.WebView.lambda$registerEventHandlers$3(WebView.java:1143)

	at javafx.base/com.sun.javafx.event.CompositeEventHandler$NormalEventHandlerRecord.handleBubblingEvent(CompositeEventHandler.java:247)
	at javafx.base/com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(CompositeEventHandler.java:80)
	at javafx.base/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:234)
	at javafx.base/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:191)
	at javafx.base/com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(CompositeEventDispatcher.java:59)
	at javafx.base/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:58)
	at javafx.base/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at javafx.base/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at javafx.base/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at javafx.base/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at javafx.base/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at javafx.base/com.sun.javafx.event.EventUtil.fireEventImpl(EventUtil.java:74)
	at javafx.base/com.sun.javafx.event.EventUtil.fireEvent(EventUtil.java:54)
	at javafx.base/javafx.event.Event.fireEvent(Event.java:198)
	at javafx.graphics/javafx.scene.Scene$MouseHandler.process(Scene.java:3856)
	at javafx.graphics/javafx.scene.Scene.processMouseEvent(Scene.java:1851)
	at javafx.graphics/javafx.scene.Scene$ScenePeerListener.mouseEvent(Scene.java:2584)
	at javafx.graphics/com.sun.javafx.tk.quantum.EmbeddedScene.lambda$mouseEvent$4(EmbeddedScene.java:287)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:391)
	at javafx.graphics/com.sun.javafx.tk.quantum.EmbeddedScene.lambda$mouseEvent$5(EmbeddedScene.java:280)
	at javafx.graphics/com.sun.javafx.application.PlatformImpl.lambda$runLater$10(PlatformImpl.java:447)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:391)
	at javafx.graphics/com.sun.javafx.application.PlatformImpl.lambda$runLater$11(PlatformImpl.java:446)
	at javafx.graphics/com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:96)
	at javafx.graphics/com.sun.glass.ui.gtk.GtkApplication._runLoop(Native Method)
	at javafx.graphics/com.sun.glass.ui.gtk.GtkApplication.lambda$runLoop$11(GtkApplication.java:277)
	at java.base/java.lang.Thread.run(Thread.java:831)
Exception in thread "JavaFX Application Thread" java.lang.UnsatisfiedLinkError: 'long com.sun.webkit.dom.HTMLOptionsCollectionImpl.itemImpl(long, int)'
	at javafx.web/com.sun.webkit.dom.HTMLOptionsCollectionImpl.itemImpl(Native Method)
	at javafx.web/com.sun.webkit.dom.HTMLOptionsCollectionImpl.item(HTMLOptionsCollectionImpl.java:88)
	at net.rptools.maptool.client.ui.htmlframe.HTMLWebViewManager.getDataAndSubmit(HTMLWebViewManager.java:622)
	at javafx.web/com.sun.webkit.dom.EventListenerImpl.fwkHandleEvent(EventListenerImpl.java:129)
	at javafx.web/com.sun.webkit.WebPage.twkProcessMouseEvent(Native Method)
	at javafx.web/com.sun.webkit.WebPage.dispatchMouseEvent(WebPage.java:813)
	at javafx.web/javafx.scene.web.WebView.processMouseEvent(WebView.java:1020)
	at javafx.web/javafx.scene.web.WebView.lambda$registerEventHandlers$3(WebView.java:1143)
	at javafx.base/com.sun.javafx.event.CompositeEventHandler$NormalEventHandlerRecord.handleBubblingEvent(CompositeEventHandler.java:247)
	at javafx.base/com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(CompositeEventHandler.java:80)
	at javafx.base/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:234)
	at javafx.base/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:191)
	at javafx.base/com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(CompositeEventDispatcher.java:59)
	at javafx.base/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:58)
	at javafx.base/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at javafx.base/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at javafx.base/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at javafx.base/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at javafx.base/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at javafx.base/com.sun.javafx.event.EventUtil.fireEventImpl(EventUtil.java:74)
	at javafx.base/com.sun.javafx.event.EventUtil.fireEvent(EventUtil.java:54)
	at javafx.base/javafx.event.Event.fireEvent(Event.java:198)
	at javafx.graphics/javafx.scene.Scene$MouseHandler.process(Scene.java:3856)
	at javafx.graphics/javafx.scene.Scene.processMouseEvent(Scene.java:1851)
	at javafx.graphics/javafx.scene.Scene$ScenePeerListener.mouseEvent(Scene.java:2584)
	at javafx.graphics/com.sun.javafx.tk.quantum.EmbeddedScene.lambda$mouseEvent$4(EmbeddedScene.java:287)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:391)
	at javafx.graphics/com.sun.javafx.tk.quantum.EmbeddedScene.lambda$mouseEvent$5(EmbeddedScene.java:280)
	at javafx.graphics/com.sun.javafx.application.PlatformImpl.lambda$runLater$10(PlatformImpl.java:447)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:391)
	at javafx.graphics/com.sun.javafx.application.PlatformImpl.lambda$runLater$11(PlatformImpl.java:446)
	at javafx.graphics/com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:96)
	at javafx.graphics/com.sun.glass.ui.gtk.GtkApplication._runLoop(Native Method)
	at javafx.graphics/com.sun.glass.ui.gtk.GtkApplication.lambda$runLoop$11(GtkApplication.java:277)
	at java.base/java.lang.Thread.run(Thread.java:831)

dark-ether · 2021-06-17T21:02:33Z

i was testing some more and if i change the foreach() command for something as simple as [r:'<option value="option">option</option>'] the submit button still breaks, so the bug seems to be more about macro commands printing <option> tags rather than anything specific about loops

kwvanderlinde · 2021-06-18T19:31:55Z

Can you try hardcoding the options like this?

<select id="test" name="test" multiple>
    <option value="text">text</option>
    <option value="text1">text1</option>
    <option value="text2">text2</option>
</select>

If you're seeing the same issue I am (and I think it's likely), then this is entirely a bug with multiple and has nothing to do with macros per se.

dark-ether · 2021-06-20T23:51:21Z

after trying what you recommended i still saw the bug, which seems to indicate that the problem is with any select element with a a multiple attribute and at least one option element. should i change the issue to better reflect the bug? or close this one and open another one

Phergus · 2021-06-21T00:33:48Z

@dark-ether you can just edit this one.

bubblobill · 2021-07-01T18:54:38Z

tested the following in 1.9.2 Win 10 (tried with multiple and multiple="true")

[frame5("test"):{
<form action="[r:link]" method="json">
	<select id="test" name="test" multiple="true">
	    [r, for(i, 0, 10):'<option value="text'+i+'">text'+i+'</option>']
	</select>	
	<br>
	<input name="submit" type="submit" value="sucess" name="submit">
</form>
}]

Worked as expected producing this output

{
    "submit": "sucess",
    "test":     [
        "text1",
        "text7",
        "text8",
        "text9"
    ]
}

aliasmask · 2021-08-31T19:54:54Z

Should this issue be closed now?

Phergus · 2021-08-31T21:25:31Z

@kwvanderlinde thoughts?

kwvanderlinde · 2021-08-31T22:08:58Z

I don't think we should close this. This may well be JavaFX's fault, but it's our problem and our users not being able to do what they need.

Before this gets closed, we should establish the following:

It's definitely JavaFX's fault and not in any way our fault.
There's no better way to do what we need and which may avoid the issue.
There is an open bug report for JavaFX so they know about it.
There isn't another JavaFX version or build that already fixes the issue.

Phergus · 2021-10-03T17:18:40Z

Can someone on Linux test the fixes? Still works fine on Windows.

kwvanderlinde · 2021-10-03T19:43:44Z

Tested latest develop on Linux Mint 20.2. Can submit a form containing a <select multiple>, with all selected values being submitted.

Phergus · 2021-10-03T20:06:05Z

@kwvanderlinde I kind of assumed that it would work for you since you submitted the PR. :)

Was hoping someone else that is not the person submitting the fix would test it. Even better would be under a different distro.

kwvanderlinde · 2021-10-04T07:27:09Z

Yeah I figured as much, just didn't want to leave you hanging there!

Testing on a Mac would be good as well. When I was looking through the library symbols, I noticed the Macs binaries are missing the same symbols as the linux binaries and so should be experiencing the same problem. This bug report on Melek's lib:elevation confirms that suspicion.

Phergus · 2021-10-04T12:53:59Z

Yup. Looking closer I see that you updated the run section of the build file but not the jpackage section. Going to need both.

Phergus · 2021-10-06T19:42:13Z

Tested latest changes with a jpackage build and still working under Windows.

Confirmation of same under Linux and Mac would be nice.

Phergus · 2021-10-06T19:49:29Z

Closing for now. If problems show up can be addressed then.

dark-ether added the bug label Jun 16, 2021

dark-ether changed the title ~~loops inside <select multiple> element prevent form from submitting~~ <select> element with multiple attribute containing a <option> element prevent form from being submitted Jun 21, 2021

kwvanderlinde mentioned this issue Sep 1, 2021

Work around missing JavaFX symbols on linux. #2933

Merged

Phergus assigned kwvanderlinde Sep 2, 2021

Phergus added this to To do in MapTool 1.10.0 via automation Sep 2, 2021

Phergus moved this from To do to In progress in MapTool 1.10.0 Sep 2, 2021

melek mentioned this issue Sep 8, 2021

Elevation selection list not working on Linux or MacOS melek/lib_elevation#7

Closed

Phergus changed the title ~~<select> element with multiple attribute containing a <option> element prevent form from being submitted~~ <select> element with multiple attribute containing an <option> element prevents form from being submitted Oct 3, 2021

Phergus moved this from In progress to Review in progress in MapTool 1.10.0 Oct 3, 2021

kwvanderlinde mentioned this issue Oct 4, 2021

Open com.sun.webkit.dom in jpackage section to match run section #3008

Merged

Phergus closed this as completed Oct 6, 2021

Phergus moved this from Review in progress to Reviewer approved in MapTool 1.10.0 Oct 6, 2021

Phergus moved this from Reviewer approved to Done in MapTool 1.10.0 Oct 6, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

<select> element with multiple attribute containing an <option> element prevents form from being submitted #2741

<select> element with multiple attribute containing an <option> element prevents form from being submitted #2741

dark-ether commented Jun 16, 2021 •

edited by Phergus

kwvanderlinde commented Jun 17, 2021 •

edited by Phergus

dark-ether commented Jun 17, 2021

kwvanderlinde commented Jun 18, 2021

dark-ether commented Jun 20, 2021 •

edited

Phergus commented Jun 21, 2021

bubblobill commented Jul 1, 2021

aliasmask commented Aug 31, 2021

Phergus commented Aug 31, 2021

kwvanderlinde commented Aug 31, 2021

Phergus commented Oct 3, 2021

kwvanderlinde commented Oct 3, 2021

Phergus commented Oct 3, 2021

kwvanderlinde commented Oct 4, 2021

Phergus commented Oct 4, 2021

Phergus commented Oct 6, 2021

Phergus commented Oct 6, 2021

<select> element with multiple attribute containing an <option> element prevents form from being submitted #2741

<select> element with multiple attribute containing an <option> element prevents form from being submitted #2741

Comments

dark-ether commented Jun 16, 2021 • edited by Phergus

kwvanderlinde commented Jun 17, 2021 • edited by Phergus

dark-ether commented Jun 17, 2021

kwvanderlinde commented Jun 18, 2021

dark-ether commented Jun 20, 2021 • edited

Phergus commented Jun 21, 2021

bubblobill commented Jul 1, 2021

aliasmask commented Aug 31, 2021

Phergus commented Aug 31, 2021

kwvanderlinde commented Aug 31, 2021

Phergus commented Oct 3, 2021

kwvanderlinde commented Oct 3, 2021

Phergus commented Oct 3, 2021

kwvanderlinde commented Oct 4, 2021

Phergus commented Oct 4, 2021

Phergus commented Oct 6, 2021

Phergus commented Oct 6, 2021

dark-ether commented Jun 16, 2021 •

edited by Phergus

kwvanderlinde commented Jun 17, 2021 •

edited by Phergus

dark-ether commented Jun 20, 2021 •

edited