Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple strings missing from translation file #2837

Closed
Azhrei opened this issue Jul 1, 2021 · 6 comments · Fixed by #3707
Closed

Multiple strings missing from translation file #2837

Azhrei opened this issue Jul 1, 2021 · 6 comments · Fixed by #3707
Assignees
@ChrisCookOC
Labels
bug good first issue A good issue for people wanting to contribute to start with Hacktoberfest little or no coding Little or no coding is required tested This issue has been QA tested by someone other than the developer. translations

Comments

@Azhrei
Copy link
Member

Azhrei commented Jul 1, 2021

Describe the bug
The token editor dialog is missing multiple keys in the properties file. (Not sure I got the tags right for this issue.)

To Reproduce
Steps to demonstrate missing keys:

  1. Start MapTool
  2. Turn on debugging for the I18N module via [setLevel("net.rptools.maptool.language.I18N", "DEBUG")]
  3. Drag an image to the map and double-click it.
  4. The log file will show which keys are not being found.

MapTool Info

  • Version: 1.9.2 (and probably 1.5+; all that have token VBL or HeroLab support)
  • Install: New

Desktop (please complete the following information):

  • OS: macOS
  • Version 11.4 (Big Sur, fully updated)

Additional context
These are the keys found by scanning the maptool.log content. The order shown here is the order they appear in the log file, but sorting them shows some strings occur multiple times (the empty string, Enter raw text..., Expression: , Find, and Search the statblock...).

Cannot find key 'Image' in properties file.
Cannot find key 'propertiesTable' in properties file.
Cannot find key 'VBL Preview' in properties file.
Cannot find key '' in properties file.
Cannot find key 'Adjust the sensitivity to the color match that will be used to generate VBL, values 0-255 with 0 being an exact color match.' in properties file.
Cannot find key 'ownerShipLabel' in properties file.
Cannot find key '' in properties file.
Cannot find key '' in properties file.
Cannot find key '' in properties file.
Cannot find key '' in properties file.
Cannot find key 'MULTIPLY' in properties file.
Cannot find key '' in properties file.
Cannot find key '100%' in properties file.
Cannot find key 'Charsheet' in properties file.
Cannot find key 'Layout' in properties file.
Cannot find key 'Portrait' in properties file.
Cannot find key 'HTML' in properties file.
Cannot find key 'XML' in properties file.
Cannot find key 'TEXT' in properties file.
Cannot find key 'Images' in properties file.
Cannot find key 'Expression: ' in properties file.
Cannot find key 'Enter raw text, a regular expression or an xPath expresstion to search the statblock for.' in properties file.
Cannot find key 'Find' in properties file.
Cannot find key 'Search the statblock using the expression provided.' in properties file.
Cannot find key 'xmlStatblockRTextScrollPane' in properties file. 
Cannot find key 'Find' in properties file.
Cannot find key 'Search the statblock using the expression provided.' in properties file.
Cannot find key 'Expression: ' in properties file.
Cannot find key 'Enter raw text, a regular expression or an xPath expresstion to search the statblock for.' in properties file.
Cannot find key 'textStatblockRTextScrollPane' in properties file.
Cannot find key 'Set as Token Handout' in properties file.
Cannot find key 'Set as Token Image' in properties file.
Cannot find key 'Set as Token Portrait' in properties file.
Cannot find key 'EditTokenDialog.label.hero.portfolio ' in properties file.
Cannot find key 'summaryText' in properties file.
Cannot find key 'portfolioLocation' in properties file.
Cannot find key 'lastModified' in properties file.
Cannot find key 'Ally?' in properties file.
Cannot find key '' in properties file.
Cannot find key '<html>Refresh data from Hero Lab<br/>
@Azhrei Azhrei added bug little or no coding Little or no coding is required translations labels Jul 1, 2021
@cwisniew cwisniew added the good first issue A good issue for people wanting to contribute to start with label Jul 4, 2021
@FullBleed
Copy link

I saw someone show a screen shot from a non-English version and noticed that the "Map not visible to players" screen flag was all in English. It was the only English on the screen so I suspect that may be missing from the translation file, too.

@ChrisCookOC
Copy link
Contributor

I'm having a go at this one currently.

@ChrisCookOC
Copy link
Contributor

I saw someone show a screen shot from a non-English version and noticed that the "Map not visible to players" screen flag was all in English. It was the only English on the screen so I suspect that may be missing from the translation file, too.

Looks like that is just a case of no-one translating that string.

@ChrisCookOC ChrisCookOC mentioned this issue Oct 11, 2022
Merged
@ChrisCookOC
Copy link
Contributor

Might be worth considering whether we should be logging the cases where we fail to find a translation for the empty key. I'm not entirely convinced the empty-string should ever be calling internationalisation code though, so perhaps this should be handled at the root cause.

@Irarara
Copy link
Contributor

Irarara commented Oct 11, 2022 •
edited

For some of these strings like "summaryText", "lastModified", etc., are these actually visible to users? Because they look like internal names that are getting processed because they're part of a form, not like strings that should be localized.

Edit: Yeah, checking more closely, I believe for ones like those the fields are automatically populated with data from the HeroLab token so those strings should never be visible. Rather than being included as i18n strings, it may be better for the default text to be blank.

@ChrisCookOC ChrisCookOC mentioned this issue Oct 14, 2022
Merged
@Phergus
Copy link
Contributor

Phergus commented Feb 20, 2023

More strings added to translation file. Fixes for protobuf initialization issues.

@Phergus Phergus closed this as completed Feb 20, 2023
@Phergus Phergus added the tested This issue has been QA tested by someone other than the developer. label Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChrisCookOC ChrisCookOC

Labels
bug good first issue A good issue for people wanting to contribute to start with Hacktoberfest little or no coding Little or no coding is required tested This issue has been QA tested by someone other than the developer. translations
Projects
MapTool 1.13.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Missing internationalisation strings
6 participants
@cwisniew @Azhrei @Phergus @FullBleed @Irarara @ChrisCookOC