js.eval, js.evalNS, and js.evalURI use case sensitive comparisons for determining which to run

[cwisniew]

Describe the bug
The code for js.eval, js.evalNS, and js.evalURI all check functionName using a case sensitive comparison. As the parser does not check for case when calling the functions this leads to confusing issues if the user attempts to run one of these functions using the wrong case (e.g. js.evalns()).

To Reproduce
Try to execute js.evalURI as js.evaluri and you will get an error as it attempts to parse the URI as javascript.

Expected behaviour
To be consistent with the parser and other MTScript functions these should accept any case.

MapTool Info

• Latest develop branch

[kwvanderlinde]

It's worth noting that this isn't specific to the JS functions. E.g., getvbl() will similarly generate an "Unknown function" error. In fact, it seems most of our functions use case-sensitive comparisions based on this quick estimate:

> grep -rn . -e 'functionName' | grep '.equals(' --color=always | wc -l
289
> grep -rn . -e 'functionName' | grep '.equalsIgnoreCase(' --color=always | wc -l
153

[cwisniew]

It's worth noting that this isn't specific to the JS functions. E.g., getvbl() will similarly generate an "Unknown function" error. In fact, it seems most of our functions use case-sensitive comparisions based on this quick estimate:

> grep -rn . -e 'functionName' | grep '.equals(' --color=always | wc -l
289
> grep -rn . -e 'functionName' | grep '.equalsIgnoreCase(' --color=always | wc -l
153

oh yay more stuff to fix! :)
I will create a new issue for this. I fixed this one as I was already editing the code (that and I spent 40 minutes wondering why my changes to "Allow URI Access" didn't work when testing). Problem here was no tthe "Unknown function" but it executing the wrong thing...

[Phergus]

Tested.