Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serializing should use the XML library instead of printing strings #39

Open
Michael-F-Bryan opened this issue Aug 24, 2017 · 3 comments

Comments

@Michael-F-Bryan
Copy link
Contributor

When I initially wrote the Serializer I was just using write!() to write the XML as a string to an internal io::Writer.

Ideally we should be using the xml-rs library instead so can guarantee the generated XML is syntactically correct, plus we'd get things like pretty-printing for free.

@Michael-F-Bryan
Copy link
Contributor Author

@oli-obk, any chance you can add the "Refactor" label to this?

@farodin91
Copy link
Contributor

I could start working on it.

@Michael-F-Bryan
Copy link
Contributor Author

You may want to hang out until we merge #36. I've gone through and added support for serializing all the serde data types, so we'd end up stepping on each others toes and have annoying merge conflicts.

After that you can just go through and swap out write!() statements with pushing an XML event to a xml_rs::EventWriter. It shouldn't be overly difficult because all the structure is there, we just need to swap out where things get written to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants