New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support docker #14
Support docker #14
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 17 +1
Lines 311 321 +10
=========================================
+ Hits 311 321 +10
Continue to review full report at Codecov.
|
Thanks for your contribution! Here are two of my concerns:
|
Q1 Q2 ref.
|
.dockerignore
Outdated
dist/ | ||
|
||
# Docs | ||
site/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update .dockerignore
, add the content in .gitignore.
PTAL @queensferryme
I made quite some changes to the PR:
I am not so sure about the removal of I will merge if @EurusEurus are okay with these changes. |
LGTM @queensferryme
|
Thanks. I will use docker-slim in github actions. |
8db1677
to
fd7aaf6
Compare
Add Dockerfile, use gosu run specific application as specific user.
What problem does this PR solve?
Issue Number: close #13
What is changed and how it works?