TypeScrpit init(): A object property is processed as an array of objects.

[homam1]

If the model in the API contains a field from type object, it is converting string to an array of charecters during the init.

The DTO in my case is:

public class FilterDto 
    {
        public long FieldId { get; set; }
        public FilterOperator Operator { get; set; }
        public object Value { get; set; }
    }

The generated code is:

export class FilterDto implements IFilterDto {
    fieldId: number | undefined;
    operator: FilterDtoOperator | undefined;
    value: any | undefined;
    viewId: number | undefined;
    id: number | undefined;

    constructor(data?: IFilterDto) {
        if (data) {
            for (var property in data) {
                if (data.hasOwnProperty(property))
                    (<any>this)[property] = (<any>data)[property];
            }
        }
    }

    init(data?: any) {
        if (data) {
            this.fieldId = data["fieldId"];
            this.operator = data["operator"];
            if (data["value"]) {
                this.value = {};

// HERE IS THE PROBLEM. The string is broken down to an array of char
                for (let key in data["value"]) {
                    if (data["value"].hasOwnProperty(key))
                        this.value[key] = data["value"][key];
                }
            }
            this.viewId = data["viewId"];
            this.id = data["id"];
        }
    }

}

So, when the filter.value is a string, it is generated as an array of char.

[homam1]

Is there any workaround for this issue? Can I override the init function externally?
@RSuter

[RicoSuter]

Hmm, I think there is no easy workaround. I'd say this is a bug as any/object should be just assigned and not looped through the properties. Or add another a check whether the var contains an object (for) or a primitive (assign)?

[homam1]

I see. Is there any way yo override the whole method and write it myself?

[RicoSuter]

Maybe by overriding the correct template:
https://github.com/RSuter/NJsonSchema/wiki/Templates

[RicoSuter]

Somehow it’s treated as dictionary:
https://github.com/RSuter/NJsonSchema/blob/master/src/NJsonSchema.CodeGeneration.TypeScript/Templates/Class.liquid#L41

[RicoSuter]

This is the condition for dictionary:
https://github.com/RSuter/NJsonSchema/blob/master/src/NJsonSchema/JsonSchema4.cs#L664

[RicoSuter]

Can you post the generated schema?

[homam1]

I already did in the post. I've posted the generated TypeScript code

[RicoSuter]

... the JSON Schema which is generated from the DTO.

[RicoSuter]

In this test everything looks fine: 21ce1da

Also the generated output from the schema:

[homam1]

Actually this happened after an update to the swagger library to the latest version. Can you please try with this schema?

https://workiom-dev.azurewebsites.net/swagger

[RicoSuter]

What library are you using?

[homam1]

Swashbuckle.AspNetCore.SwaggerGen, Version=2.4.0.0

[mutzl]

Strings are generated as char arrays. But even worse - other types like boolean, are empty!
So this is really a show stopper.

[RicoSuter]

How exactly does the Swagger spec for this look like when generated by Swashbuckle? Somehow NJS treats it as dictionary when it's actually an object (objects are directly assigned, dictionaries are copied)