Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weather API migration before end of 2021 #134

Closed
rasmusgerdin opened this issue Aug 17, 2020 · 6 comments
Closed

Weather API migration before end of 2021 #134

rasmusgerdin opened this issue Aug 17, 2020 · 6 comments
Assignees
@rasmusgerdin
Labels
Meta: Feature Issues and PRs related to new features. Priority: Low Issues that must be fixed or PRs that must be finished and merged with low priority. Type: Proposal Issues that request a new feature or a change to the bot.
Projects
The RTByte Project TS & Sapphire rewrite
Milestone
TypeScript & Sapp...

Comments

@rasmusgerdin
Copy link
Member

rasmusgerdin commented Aug 17, 2020 •
edited
Loading

Describe the feature you'd like to see.
We need to migrate from DarkSky's weather API to another weather API before the end of 2021 to ensure the continued functionality of the weather command. DarkSky is shutting down their API at the end of 2021.

Suggestions for new weather APIs:
@rasmusgerdin rasmusgerdin added Type: Proposal Issues that request a new feature or a change to the bot. Priority: Low Issues that must be fixed or PRs that must be finished and merged with low priority. Meta: Feature Issues and PRs related to new features. labels Aug 17, 2020
@rasmusgerdin rasmusgerdin added this to To-do in The RTByte Project via automation Aug 17, 2020
@rasmusgerdin
Copy link
Member Author

@RTByte/developers any thoughts around which API we should use?

@Uzui2012
Copy link
Contributor

Looks like OpenWeather have areally easy to follow migrating documentation off of DarkSky, I'd reckon that would be simply easiest to do

@rasmusgerdin
Copy link
Member Author

I'm leaning towards OpenWeather as well. Not only does their documentation seem like it's the clearest out of all of them, but their usage limits also seem very good.

@rasmusgerdin
Copy link
Member Author

We'll be using OpenWeather's One Call API to do this.

@rasmusgerdin rasmusgerdin mentioned this issue Aug 26, 2020
Open
@rasmusgerdin
Copy link
Member Author

This has been implemented on the ts-rewrite branch and will be merged to master as part of the larger migration to Sapphire.

@rasmusgerdin rasmusgerdin self-assigned this Jan 21, 2021
@rasmusgerdin
Copy link
Member Author

Implemented in 30812e9.

The RTByte Project automation moved this from To-do to Done Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rasmusgerdin rasmusgerdin

Labels
Meta: Feature Issues and PRs related to new features. Priority: Low Issues that must be fixed or PRs that must be finished and merged with low priority. Type: Proposal Issues that request a new feature or a change to the bot.
Projects
TS & Sapphire rewrite
  
Done
The RTByte Project
  
Done
Milestone
TypeScript & Sapphire rewrite
Development

No branches or pull requests
2 participants
@rasmusgerdin @Uzui2012