Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communications to use Modelica_DeviceDrivers #277

Closed
marcusfuchs opened this issue Oct 5, 2016 · 12 comments
Closed

Communications to use Modelica_DeviceDrivers #277

marcusfuchs opened this issue Oct 5, 2016 · 12 comments
Assignees

Comments

@marcusfuchs
Copy link

As mentioned in #149, the communication package should use https://github.com/modelica/Modelica_DeviceDrivers.

@mlauster
Copy link
Contributor

Is there anything still to do fir this issue or can it be closed, @AnaConstantin?

@mlauster
Copy link
Contributor

@AnaConstantin, could you give an update if this issue is still relevant or has been solved?

@AnaConstantin
Copy link
Collaborator

@mlauster the work still has to be done, but it is not a priority for the next release. I would leave it open.

@mlauster
Copy link
Contributor

@AnaConstantin, just a quick update, is this still an open issue?

@AnaConstantin
Copy link
Collaborator

It is still open. I looked over it again. It might take some time to implement, but it is very interesting, since the TCP/IP interface in ModelicaDeviceDrivers seems to be more robustely constructed.

@tbeu
Copy link
Contributor

tbeu commented Nov 20, 2017

I gave three reasons in #149 (comment) why current design has some drawbacks.
I recommend to apply the function layer API of the M_DD communication interface only and avoid the blocks layer API.

It might take some time to implement,

Since it is not complex to do it, I believe it is some resource=time constraint, which is the bottleneck to keep this issue open for more than 13 months.

@mlauster
Copy link
Contributor

mlauster commented Aug 8, 2018

@AnaConstantin, I don't think there is much to happen here, can we close this?

@tbeu
Copy link
Contributor

tbeu commented Aug 8, 2018

I really wonder why there is no progress, but see my comment above from 20 Nov 2017.

@mlauster
Copy link
Contributor

mlauster commented Aug 8, 2018

@tbeu, @AnaConstantin is in parental leave and so far nobody else took over this work. I will see with @AnaConstantin how to proceed here. Thanks for your input and interest!

@mlauster
Copy link
Contributor

mlauster commented Aug 9, 2018

Just to wrap up what still needs to be done here: Scan our Communications Package and make use of https://github.com/modelica/Modelica_DeviceDrivers. All parts that cannot be used to extend the functionalities of Modelica Device Drivers should be deleted.

@AnaConstantin
Copy link
Collaborator

Tested the new implementation by @tbeu. The example provides the same results.
Revised the UserGuide: referenced the old implementation and where to find it, deleted the documentation part as it no loger applies.
Added a reference to the issue number to all the revision texts.
Deleted the AixLibSocketCommunication.h file for the library and the AixLib.Utilities.Communication.SocketCommunication.Functions-Package.
@tbeu would you please check out the current version and let me know if anything seems wrong or improvable? If everything is ok, could you please make a pull request? I will review it and be done with these issues.
Thank you in advance!

@AnaConstantin
Copy link
Collaborator

Resolved through #722

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants