Remove Pattern lib dependency in News Classification tutorial #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes sure the user has downloaded the 'stopwords' package from NLTK without having to do it from shell. Signed-off-by: Luiz Carlos Cavalcanti <cavalcanti.luiz@gmail.com>
Since Pattern lib is not supported yet on Python 3, NLTK is now used also for lemmatization, removing the dependency for Pattern. Now it should be possible to run this tutorial ob both Python 2.5+ and 3.x. Signed-off-by: Luiz Carlos Cavalcanti <cavalcanti.luiz@gmail.com>
|
Thanks for supporting Python 3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even thought NLTK is old and all, Pattern does not currently work on Python3. So changing this tutorial to use NLTK for lemmatization makes it possible to work on both python 2.5+ and 3.x. We are also making sure the user has its NLTK packages downloaded and up-to-date.