Explain new concepts introduced in corpus streaming example #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Could you please put the explanation before the code? "We are going to ..." |
In code snippet 13 there are two new concepts introduced that have not been explained yet. In addition the workflow to create the dictionary here is completely different from the workflow described in code snippets 4 and 5. I've added a paragraph that tries to explain the new workflow and concepts.
|
@tmylk Explaination moved. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add paragraph describing dictionary.dfs and dictionary.compactify()
In code snippet 13 there are two new concepts introduced that have not
been explained yet. In addition the workflow to create the dictionary
here is completely different from the workflow described in code
snippets 4 and 5. I've added a paragraph that tries to explain the new
workflow and concepts.