Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Punctuation & typo fixes to CHANGELOG #1366

Merged
merged 32 commits into from
May 29, 2017
Merged

Punctuation & typo fixes to CHANGELOG #1366

merged 32 commits into from
May 29, 2017

Conversation

piskvorky
Copy link
Owner

@piskvorky piskvorky commented May 27, 2017

Also includes commits from master (not sure why these are missing from develop -- only one commit is actually new, a8b1585).

@piskvorky
Copy link
Owner Author

piskvorky commented May 27, 2017

@menshikh-iv @tmylk I'd also suggest type-settings the release names (version) as a heading.

It should be easier to navigate the (huge) CHANGELOG file if the versions are visually delimited like that, as headings.

@menshikh-iv
Copy link
Contributor

menshikh-iv commented May 27, 2017

@piskvorky In the future, I plan to work with our readme/changelog/doc. I would like to do more structured and useful readme for new users.

@piskvorky
Copy link
Owner Author

@menshikh-iv that's fine.

This PR is only about the CHANGELOG -- please format the headings & keep its structure and formatting consistent.

@tmylk tmylk merged commit 3ae7717 into develop May 29, 2017
@@ -6,7 +6,7 @@ Unreleased:

===========
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This heading doesn't render correctly.

@piskvorky piskvorky deleted the pep8_fixes3 branch May 30, 2017 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants