fix kullback_leibler doc #1373
Merged
fix kullback_leibler doc #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the return value range should in <0,+∞>
menshikh-iv
suggested changes
May 29, 2017
gensim/matutils.py
Outdated
| @@ -446,7 +446,7 @@ def isbow(vec): | |||
| def kullback_leibler(vec1, vec2, num_features=None): | |||
| """ | |||
| A distance metric between two probability distributions. | |||
| Returns a distance value in range <0,1> where values closer to 0 mean less distance (and a higher similarity) | |||
| Returns a distance value in range <0,+∞> where values closer to 0 mean less distance (and a higher similarity) | |||
There was a problem hiding this comment.
Please add space after ,
|
LGTM, Ready for merging. |
|
Thank you @viciousstar, sorry for this minor comments, we just want to improve the code style/doc style in gensim. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the return value range should in <0,+∞>