Added note about training mode in 'partial_fit' #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmylk
reviewed
Jun 2, 2017
| @@ -126,6 +126,8 @@ def get_topic_dist(self, bow, minimum_probability=None, minimum_phi_value=None, | |||
| def partial_fit(self, X): | |||
| """ | |||
| Train model over X. | |||
| By default, 'online' mode is used for training the LDA model. | |||
| Configure `passes` and `update_every` params at init to choose the mode among 'online', 'mini-batch', 'batch' | |||
There was a problem hiding this comment.
Please add explicit values to use
There was a problem hiding this comment.
I have updated the mode names and also added explicit values to use for each mode.
menshikh-iv
reviewed
Jun 5, 2017
| @@ -126,6 +126,11 @@ def get_topic_dist(self, bow, minimum_probability=None, minimum_phi_value=None, | |||
| def partial_fit(self, X): | |||
| """ | |||
| Train model over X. | |||
| By default, 'online (single-pass)' mode is used for training the LDA model. | |||
| Configure `passes` and `update_every` params at init to choose the mode among : | |||
There was a problem hiding this comment.
Please remove spaces before : everywhere
There was a problem hiding this comment.
Ok. Doing it right away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a note about the mode used for training in the
partial_fitfunction in the sklearn wrapper for LDA model.